Skip to content

Comments

fix: Query for tuples of size up to 20#790

Merged
k88hudson-cfa merged 1 commit intov1from
RobertJacobsonCDC_prop_list_typo_backport
Feb 20, 2026
Merged

fix: Query for tuples of size up to 20#790
k88hudson-cfa merged 1 commit intov1from
RobertJacobsonCDC_prop_list_typo_backport

Conversation

@RobertJacobsonCDC
Copy link
Collaborator

@RobertJacobsonCDC RobertJacobsonCDC commented Feb 20, 2026

A version of #789 for the v1.0 branch.

Is this the right target branch for v1.0 fixes?

@RobertJacobsonCDC RobertJacobsonCDC force-pushed the RobertJacobsonCDC_prop_list_typo_backport branch from e27a966 to 3b8e3a1 Compare February 20, 2026 15:28
@github-actions
Copy link

Benchmark Results

Hyperfine

  Group                  Bench                     Mean [ms]  Min [ms]  Max [ms]       Relative
  ---------------------  ---------------------  ------------  --------  --------  -------------
  large_sir              baseline                  3.0 ± 0.1       2.9       3.3           1.00
  large_sir              ixa                     142.3 ± 2.2     140.1     152.8   48.23 ± 1.38
  large_sir              ixa_no_queries           35.5 ± 1.2      33.8      40.7   12.04 ± 0.51
  periodic_counts_bench  no_periodic_reports       7.3 ± 0.1       7.2       7.6           1.00
  periodic_counts_bench  with_periodic_reports    12.5 ± 0.1      12.4      12.9    1.72 ± 0.02

Criterion

Regressions:
  Group          Bench                                                         Change  CI Lower  CI Upper
  -------------  -----------------------------------------------------------  -------  --------  --------
  examples       example-basic-infection                                       0.544%    0.208%    0.891%
  examples       example-births-deaths                                         1.242%    0.934%    1.543%
  indexing       query_people_single_indexed_property                          3.915%    2.645%    5.182%
  indexing       with_query_results_multiple_individually_indexed_properties   6.574%    6.184%    6.904%
  indexing       query_people_count_multiple_individually_indexed_properties   0.193%    0.093%    0.307%
  sample_people  sampling_multiple_l_reservoir                                 2.750%    2.383%    3.107%
  sample_people  sampling_single_known_length                                  2.599%    1.948%    3.424%
  large_dataset  bench_query_population_indexed_property                       4.421%    4.221%    4.623%

Improvements:
  Group          Bench                                                         Change  CI Lower  CI Upper
  -------------  -----------------------------------------------------------  -------  --------  --------
  indexing       query_people_count_single_indexed_property                   -2.168%   -2.263%   -2.064%
  indexing       query_people_multiple_individually_indexed_properties        -0.382%   -0.487%   -0.282%
  sample_people  sampling_multiple_known_length                               -0.575%   -1.006%   -0.127%
  large_dataset  bench_query_population_property                              -1.461%   -1.701%   -1.259%
  large_dataset  bench_query_population_derived_property                      -1.581%   -1.820%   -1.359%
  large_dataset  bench_query_population_multi_unindexed                       -0.641%   -0.988%   -0.386%
  large_dataset  bench_query_population_multi_indexed                         -1.050%   -1.444%   -0.648%

Unchanged:
  Group          Bench                                                         Change  CI Lower  CI Upper
  -------------  -----------------------------------------------------------  -------  --------  --------
  indexing       with_query_results_indexed_multi-property                    -0.097%   -0.412%    0.150%
  indexing       query_people_count_indexed_multi-property                    -0.026%   -0.302%    0.328%
  indexing       with_query_results_single_indexed_property                    0.200%   -0.318%    0.764%
  indexing       query_people_indexed_multi-property                           0.237%   -0.009%    0.512%
  sample_people  sampling_single_l_reservoir                                   0.129%   -0.059%    0.301%

@github-actions
Copy link

Benchmark Results

Hyperfine

  Group                  Bench                     Mean [ms]  Min [ms]  Max [ms]       Relative
  ---------------------  ---------------------  ------------  --------  --------  -------------
  periodic_counts_bench  no_periodic_reports       7.5 ± 0.6       7.3      11.5           1.00
  periodic_counts_bench  with_periodic_reports    12.9 ± 0.8      12.5      18.1    1.71 ± 0.18
  large_sir              baseline                  2.9 ± 0.1       2.8       3.2           1.00
  large_sir              ixa                     143.3 ± 4.4     139.7     169.1   49.56 ± 1.90
  large_sir              ixa_no_queries           36.2 ± 1.8      34.3      41.9   12.51 ± 0.70

Criterion

Regressions:
  Group          Bench                                                         Change  CI Lower  CI Upper
  -------------  -----------------------------------------------------------  -------  --------  --------
  indexing       query_people_single_indexed_property                          0.757%    0.664%    0.880%
  indexing       with_query_results_multiple_individually_indexed_properties   1.732%    0.890%    2.233%
  indexing       query_people_count_multiple_individually_indexed_properties   1.150%    1.013%    1.262%
  sample_people  sampling_multiple_l_reservoir                                 0.279%    0.217%    0.348%
  sample_people  sampling_multiple_known_length                                0.293%    0.236%    0.355%
  large_dataset  bench_query_population_multi_unindexed                        1.405%    1.012%    1.764%
  large_dataset  bench_query_population_multi_indexed                          1.323%    1.160%    1.471%

Improvements:
  Group          Bench                                                         Change  CI Lower  CI Upper
  -------------  -----------------------------------------------------------  -------  --------  --------
  examples       example-basic-infection                                      -7.430%   -9.158%   -6.023%
  examples       example-births-deaths                                        -2.429%   -2.685%   -2.149%
  indexing       with_query_results_indexed_multi-property                    -2.536%   -2.791%   -2.267%
  indexing       with_query_results_single_indexed_property                   -1.081%   -1.447%   -0.794%
  indexing       query_people_multiple_individually_indexed_properties        -1.157%   -1.325%   -1.040%
  indexing       query_people_indexed_multi-property                          -3.236%   -3.529%   -2.964%
  sample_people  sampling_single_known_length                                 -0.161%   -0.269%   -0.055%
  large_dataset  bench_query_population_property                              -2.237%   -2.558%   -2.035%
  large_dataset  bench_query_population_derived_property                      -3.699%   -4.144%   -3.163%

Unchanged:
  Group          Bench                                                         Change  CI Lower  CI Upper
  -------------  -----------------------------------------------------------  -------  --------  --------
  indexing       query_people_count_single_indexed_property                    0.134%   -0.100%    0.392%
  indexing       query_people_count_indexed_multi-property                    -0.103%   -0.311%    0.117%
  sample_people  sampling_single_l_reservoir                                  -0.160%   -0.935%    0.297%
  large_dataset  bench_query_population_indexed_property                      -0.244%   -0.682%    0.212%

@k88hudson-cfa k88hudson-cfa merged commit d210986 into v1 Feb 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants